linux-kernel - Re: `make oldconfig' no longer updating `.config.old'?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080804201040.GA28982@uranus.ravnborg.org>
Date:	Mon, 4 Aug 2008 22:10:40 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-kbuild@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Tim Bird <tim.bird@...sony.com>
Subject: Re: `make oldconfig' no longer updating `.config.old'?

On Mon, Aug 04, 2008 at 09:02:43AM +0200, Geert Uytterhoeven wrote:
> 	Hi,
> 
> I have the habit of doing `make .config{.old,}' after each config run,
> to see what was changed. But since a few weeks, `make oldconfig' no longer
> seems to update `.config.old'.
> 
> This also breaks the default behavior of `scripts/diffconfig' (`If no
> config files are specified, .config and .config.old are used.').
> 
> Was this change intentional?

.config is with current kconfig updated only if a user visible
symbol changes (or something like that).
I had another similar report where .config was not created if
missing and confi was not changed.

Fix is below and I will commit it soon.

	Sam

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 9fba838..36b5eed 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -596,7 +596,7 @@ int main(int ac, char **av)
 		break;
 	}
 
-	if (conf_get_changed() && conf_write(NULL)) {
+	if (conf_write(NULL)) {
 		fprintf(stderr, _("\n*** Error during writing of the kernel configuration.\n\n"));
 		exit(1);
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/