linux-kernel - Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080805112814.GO26461@parisc-linux.org>
Date:	Tue, 5 Aug 2008 05:28:14 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Simon Horman <horms@...ge.net.au>
Cc:	Sven Wegener <sven.wegener@...aler.net>,
	Michael Ellerman <michael@...erman.id.au>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus()

On Tue, Aug 05, 2008 at 09:14:07PM +1000, Simon Horman wrote:
> Check the return value of device_create_bin_file in pci_create_bus,
> unwind if necessary, and propagate any errors to the caller.

Yes, but you're essentially saying here that if I can't create a couple
of poxy sysfs files, I can't have this PCI bus at all?  This seems like
a bad decision to me.  I'd rather have a PCI bus without the files than
no PCI bus at all.  By all means, we should whinge mightily if we can't
create the files so the sysadmin has a chance of figuring out why things
aren't quite working right, but I might have my root filesystem on a
device on that PCI bus.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/