linux-kernel - Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API -V2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080805130408.GD25371@cs181140183.pp.htv.fi>
Date:	Tue, 5 Aug 2008 16:04:08 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Austin Zhang <austin_zhang@...ux.intel.com>, dwmw2@...radead.org,
	davem@...emloft.net, randy.dunlap@...cle.com,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c
	algorithm by new crypto API -V2.

On Tue, Aug 05, 2008 at 08:39:44PM +0800, Herbert Xu wrote:
> Hi Austin:
> 
> On Tue, Aug 05, 2008 at 07:56:43AM -0400, Austin Zhang wrote:
> > Revised by comments:
> > Move hardware feature detect into module init;
> > Revise dependency in Kconfig;
> > Revise variable type;
> > Add information output while module loading failed; 
> >  
> > 
> > >From NHM processor onward, Intel processors can support hardware
> > accelerated
> > CRC32c algorithm with the new CRC32 instruction in SSE 4.2 instruction
> > set.
> > The patch detects the availability of the feature, and chooses the most
> > proper
> > way to calculate CRC32c checksum.
> > Byte code instructions are used for compiler compatibility.
> > No MMX / XMM registers is involved in the implementation.
> > 
> > Signed-off-by: Austin Zhang <austin.zhang@...el.com>
> > Signed-off-by: Kent Liu <kent.liu@...el.com>
> 
> I tried to apply your patch but it doesn't work:
> 
> $ git apply --check --whitespace=error-all ~/p
> fatal: patch fragment without header at line 34: @@ -0,0 +1,190 @@
> $
> 
> Looks like your mail client has folded all the lines.
>...

Documentation/email-clients.txt contains a section explaining what to do 
in Evolution.

> And here.
> 
> Thanks,

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/