linux-kernel - RE: [PATCH] [PM] Fixes missing PM entries in sysfs without CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Aug 2008 10:26:27 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Dasgupta, Romit" <romit@...com>
cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	David Engraf <david.engraf@...com.eu>,
	Greg KH <greg@...ah.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>
Subject: RE: [PATCH] [PM] Fixes missing PM entries in sysfs without
 CONFIG_PM_SLEEP

On Tue, 5 Aug 2008, Dasgupta, Romit wrote:

> A minor change below: Removed old goto label PMError and introduced SysFSError.
> Tested with CONFIG_PM, CONFIG_PM_SLEEP, without CONFIG_PM and ofcourse with CONFIG_USB_SUSPEND. Works fine.

Strictly speaking, I suppose the statement label should be 
DPMSysfsError.

On the other hand, the corresponding label for
device_add_class_symlinks() is SymlinkError, not
DeviceAddClassSymlinksError.  The label for device_add_attrs() is
AttrsError, not DeviceAddAttrsError.  And the label for
bus_add_device() is BusError, not BusAddDeviceError.

Following those precedents, it seems appropriate that the label for
dpm_sysfs_add() should be DPMError.  I'll make the change and submit
the patch.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/