linux-kernel - Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808051435260.3257@nehalem.linux-foundation.org>
Date:	Tue, 5 Aug 2008 14:37:19 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Sean MacLennan <smaclennan@...atech.com>
cc:	Karsten Keil <kkeil@...e.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"Andreas.Eversberg" <Andreas.Eversberg@...satel.de>,
	isdn4linux@...tserv.isdn4linux.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

On Tue, 5 Aug 2008, Sean MacLennan wrote:
> 
> Why not select PIO or MMIO at config time?

Umm. Then you can't run a generic driver that can do either. That's the 
worst choice of all.

As to where in the stack to do the choice - I suspect it's easier if it's 
done at the lowest level, but that can cause performance issues (ie 
testing that flag over and over again). The mmio code avoids some of the 
performance issues exactly by doing the "repeat" versions - so for some 
cases you can do the check once at the top, and then just repeat.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/