linux-kernel - Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080805175937.49a5ba32@lappy.seanm.ca>
Date:	Tue, 5 Aug 2008 17:59:37 -0400
From:	Sean MacLennan <smaclennan@...atech.com>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Karsten Keil" <kkeil@...e.de>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	"Andreas.Eversberg" <Andreas.Eversberg@...satel.de>,
	<isdn4linux@...tserv.isdn4linux.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

On Tue, 5 Aug 2008 14:37:19 -0700 (PDT)
"Linus Torvalds" <torvalds@...ux-foundation.org> wrote:

> On Tue, 5 Aug 2008, Sean MacLennan wrote:
> > 
> > Why not select PIO or MMIO at config time?  
> 
> Umm. Then you can't run a generic driver that can do either. That's
> the worst choice of all.

But do we really need a generic driver that can do either? Maybe for the
current mISDN driver, but when you get to other chip ports, say the
xhfc, you have to select the low level interface at compile time. Or I
should say you currently have to select at config time.

I'm not arguing that we *have* to do it this way. I just don't think we
should throw out the simplest method without some thought. There is
some precedence for a config time option, for example the 8139too
ethernet driver.

Cheers,
   Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/