linux-kernel - Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48995D9F.4010900@s5r6.in-berlin.de>
Date:	Wed, 06 Aug 2008 10:15:27 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	jmerkey@...fmountaingroup.com
CC:	Masami Hiramatsu <mhiramat@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.27-rc1-git5 2/26] mdb: correct kprobes int3 trap

jmerkey@...fmountaingroup.com wrote on 2008-08-05:
> I was unaware of checkpatch.pl, but will run it later today and submit a
> git6 patch for any areas not in compliance with linux coding standards.

I guess you got complaints from scripts/checkpatch.pl for at least 3/4 
of all lines by now.  Some or many of the complaints will probably look 
silly.  Have a look at Documentation/CodingStyle then because it gives 
context for many of the complaints.  It also gives some rules of thumb 
for things which checkpatch.pl cannot check, e.g. legibility of global 
names.

 From what I saw, there are _many_ whitespace "deviations" in your code 
(which perhaps scripts/Lindent can help to adjust), upper case vs. lower 
case in names, and occasional functions which are deeper nested than 
probably necessary, as already mentioned.
-- 
Stefan Richter
-=====-==--- =--- --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/