linux-kernel - Re: [PATCH 2.6.26 1/25] mdb: Merkey's Kernel Debugger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080806102146.GA26936@brain>
Date:	Wed, 6 Aug 2008 11:21:46 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	jmerkey@...fmountaingroup.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.26 1/25] mdb: Merkey's Kernel Debugger

On Sun, Aug 03, 2008 at 08:10:01PM -0600, jmerkey@...fmountaingroup.com wrote:
> Netware Style Debugger for Linux written by Jeffrey Vernon Merkey

I note that all of these 25 patches have the same title, either they are
one change and would be in one patch, or more likely they are all
changing different bits of the kernel and as such could do with
meaningful titles.  For a start without that they could not be tested in
-mm as they will not load into Andrews patch tools.  Second reviewers
for the specific sub-systems or architectures touched may only look over
the patches that are relevant to them.  Without any clue in the title
they probabally won't bother.

> --- linux-2.6.26/arch/x86/kernel/reboot.c	2008-07-13 15:51:29.000000000 -0600
> +++ linux-2.6.26-mdb/arch/x86/kernel/reboot.c	2008-08-03
> 12:49:01.000000000 -0600
> @@ -425,7 +425,16 @@
>  	/* O.K Now that I'm on the appropriate processor,
>  	 * stop all of the others.
>  	 */
> +#ifdef CONFIG_MDB
> +        // do not stop the other processors if the debugger is active +  
>      {
> +           extern atomic_t inmdb;
> +           if (!atomic_read(&inmdb))
> +	      smp_send_stop();
> +        }

Now its hard to be 100% sure that this spacing is what you have in your
copy as a lot of these patches appear at first viewing to be space munged
and wrapped probabally by your mailer.  BUT, this appears to be using
non-standard indent levels.  You will have much much much less resistance
if you follow the recommendations in Documentation/CodingStyle.  Also
you may want to check the emails as they have arrived at the LKML and
see if they are the same as your original, your mail reader may be
dammaging them.

> +#else
>  	smp_send_stop();
> +#endif // CONFIG_MDB
>  #endif
> 
>  	lapic_shutdown();
> 
> By making a contribution to this project, I certify that the contribution
> was created in whole or in part by me and I have the right to submit it
> under the open source license indicated in the file
> 
> Jeffrey Vernon Merkey

This sounds very much like you are signing off your patch as per the
DCO.  If so then normally that would be done via a Signed-off-by: header
at the end of the leader, not down here.

	Signed-off-by: Jeffrey Vernon Merkey <jmerkey@...fmountaingroup.com>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/