linux-kernel - Re: [PATCH 32/33] remove >= nr_irqs checking with config_have_sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86802c440808060329u32a02d19l95de3b47ce6f3f15@mail.gmail.com>
Date:	Wed, 6 Aug 2008 03:29:54 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Mike Travis" <travis@....com>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, "Yinghai Lu" <yhlu.kernel@...il.com>
Subject: Re: [PATCH 32/33] remove >= nr_irqs checking with config_have_sparse_irq

On Wed, Aug 6, 2008 at 1:43 AM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
> ---
>  arch/x86/kernel/io_apic_64.c |   36 ++++++++++++++++++++++++------------
>  arch/x86/kernel/irq_64.c     |    2 +-
>  drivers/char/random.c        |    4 ++++
>  fs/proc/proc_misc.c          |   29 +++++++++++++++++------------
>  kernel/irq/chip.c            |   28 +++++++++++++++++++++++++++-
>  kernel/irq/manage.c          |   37 +++++++++++++++++++++++++++++++------
>  6 files changed, 104 insertions(+), 32 deletions(-)
>
> diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c
> index 8bb6565..1416925 100644
> --- a/arch/x86/kernel/io_apic_64.c
> +++ b/arch/x86/kernel/io_apic_64.c

========================================================
> @@ -2475,16 +2486,17 @@ int create_irq(void)
>        int irq;
>        int new;
>        unsigned long flags;
> -       struct irq_cfg *cfg_new;
> +       struct irq_cfg *cfg_new, *cfg;
>
>        irq = -ENOSPC;
>        spin_lock_irqsave(&vector_lock, flags);
>        for (new = (nr_irqs - 1); new >= 0; new--) {
>                if (platform_legacy_irq(new))
>                        continue;
> -               cfg_new = get_irq_cfg(new);
> -               if (cfg_new->vector != 0)
> +               cfg = get_irq_cfg_without_new(new);
> +               if (!cfg || cfg->vector != 0)
>                        continue;
> +               cfg_new = get_irq_cfg(new);
>                if (__assign_irq_vector(new, TARGET_CPUS) == 0)
>                        irq = new;
>                break;
======================================
change to create_irq is not needed, it will disabled msi

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/