linux-kernel - Re: [Ksummit-2008-discuss] Kernel Summit request for Discussion of future of ATA (libata) and IDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4899A15B.8000800@gmail.com>
Date:	Wed, 06 Aug 2008 22:04:27 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
CC:	Robert Hancock <hancockr@...w.ca>, Jeff Garzik <jeff@...zik.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	ksummit-2008-discuss@...ts.linux-foundation.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-ide <linux-ide@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [Ksummit-2008-discuss] Kernel Summit request for Discussion of
 future of ATA (libata) and IDE

Sergei Shtylyov wrote:
> Hello.
> 
> Tejun Heo wrote:
>>> +unsigned int ata_sff_data_xfer(struct ata_device *dev, unsigned char *buf,
>>> +			       unsigned int buflen, int rw)
>>> +{
>>> +	struct ata_port *ap = dev->link->ap;
>>> +	void __iomem *data_addr = ap->ioaddr.data_addr;
>>> +	unsigned int words = buflen >> 2;
>>>     
>> dwords maybe?
>>   
> 
>    Isn't word 32-bit in the 32-bit systems? We're not on 80[12]86 
> (despite Intel/MS preference of calling 32-bit memory cells DWORDS)...

Well, as most of machines are 64-bit these days, discussing whether a
word means 16 or 32 bits is kind of moot.  I usually just think byte,
word, dword, qword and and libata and pci assume that too -
ata_id_has_dword_io() and PCI configuration accessors.  It's ultimately
a peripheral issue either way tho.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/