linux-kernel - Re: [PATCH]: PCI: GART iommu alignment fixes [v2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4899A5BF.1040802@redhat.com>
Date:	Wed, 06 Aug 2008 09:23:11 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
CC:	jbarnes@...tuousgeek.org, joro@...tes.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH]: PCI: GART iommu alignment fixes [v2]


>>
>>  
>>> @@ -265,7 +268,7 @@ static dma_addr_t dma_map_area(struct device 
>>> *dev, dma_addr_t phys_mem,
>>>  static dma_addr_t
>>>  gart_map_simple(struct device *dev, phys_addr_t paddr, size_t size, 
>>> int dir)
>>>  {
>>> -    dma_addr_t map = dma_map_area(dev, paddr, size, dir);
>>> +    dma_addr_t map = dma_map_area(dev, paddr, size, dir, size - 1);
>>>     
>
> Maybe I'm missing something -- what implies  size has to be a power of 
> two?
>
> P.
>

Ixnay that last comment -- I geddit (duh.).

The implication of "size-1" is that size is always a power of two.

Jesse -- I'll have to post a follow-up patch to fix this.

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/