linux-kernel - Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080806001845.GA25470@pingi.kke.suse.de>
Date:	Wed, 6 Aug 2008 02:18:45 +0200
From:	Karsten Keil <kkeil@...e.de>
To:	Sean MacLennan <smaclennan@...atech.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Karsten Keil <kkeil@...e.de>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"Andreas.Eversberg" <Andreas.Eversberg@...satel.de>,
	isdn4linux@...tserv.isdn4linux.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti

On Tue, Aug 05, 2008 at 05:59:37PM -0400, Sean MacLennan wrote:
> On Tue, 5 Aug 2008 14:37:19 -0700 (PDT)
> "Linus Torvalds" <torvalds@...ux-foundation.org> wrote:
> 
> > On Tue, 5 Aug 2008, Sean MacLennan wrote:
> > > 
> > > Why not select PIO or MMIO at config time?  
> > 
> > Umm. Then you can't run a generic driver that can do either. That's
> > the worst choice of all.
> 
> But do we really need a generic driver that can do either? Maybe for the
> current mISDN driver, but when you get to other chip ports, say the
> xhfc, you have to select the low level interface at compile time. Or I
> should say you currently have to select at config time.

For cards based on the HFC mulit chips we need runtime detection, since not
all card support both access methods and this is the only way how
distributions can support all cards.

For the xhfc this may be a differnt choice, to select the access method on
compile time, because the chip is mainly used for embedded systems, so it
do not need to have a generic driver, the kerne is usually configured
exactly for the hardware. On the other side, if you look into the xhfc
chip and documentation, it is not so different from the HFC 4/8S, so maybe
it would be possible to integrate it in hfcmulti as well.

And maybe here is a third way, to have a tristate CONFIG MEMIO,PIO,BOTH,
which could be imlemented in the none indirect call version without
overhead. I think I like this idea.

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/