linux-kernel - Re: [PATCH 1/2] pata_legacy: export functionality to ide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080806204636.220ec693@lxorguk.ukuu.org.uk>
Date:	Wed, 6 Aug 2008 20:46:36 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	petkovbb@...il.com
Cc:	petkovbb@...glemail.com, Sergei Shtylyov <sshtylyov@...mvista.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH 1/2] pata_legacy: export functionality to ide

> So the comment in there saying that in some cases BAR0-3 could contain junk is a
> bogus? In other words, can we assume that one will always read 0x1f0 from BAR0
> and 0x170 from BAR2 in compatibility mode. If so, the check is even simpler:
> 
> 	if (pci_resource_start(p, 0) == 0x1f0)
> 		*primary = 1;
> 	if (pci_resource_start(p, 2) == 0x170)
> 		*secondary = 1;

In theory, but for the sake of about 30 bytes of code in an obscure 'last
resort work everywhere' driver it seemed a bit pointless.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/