linux-kernel - Re: [PATCH 4/6] kexec jump: in sync with hibernation implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080807092241.GE372@atrey.karlin.mff.cuni.cz>
Date:	Thu, 7 Aug 2008 11:22:42 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Huang Ying <ying.huang@...el.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	nigel@...el.suspend2.net, "Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Vivek Goyal <vgoyal@...hat.com>, mingo@...e.hu,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Kexec Mailing List <kexec@...ts.infradead.org>
Subject: Re: [PATCH 4/6] kexec jump: in sync with hibernation implementation

> Add device_pm_lock() and device_pm_unlock() in kernel_kexec() to be
> in sync with current hibernation implementation.
> 
> Signed-off-by: Huang Ying <ying.huang@...el.com>
> 
> ---
>  kernel/kexec.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1457,6 +1457,7 @@ int kernel_kexec(void)
>  		error = disable_nonboot_cpus();
>  		if (error)
>  			goto Resume_devices;
> +		device_pm_lock();
>  		local_irq_disable();
>  		/* At this point, device_suspend() has been called,
>  		 * but *not* device_power_down(). We *must*
> @@ -1485,6 +1486,7 @@ int kernel_kexec(void)
>  		device_power_up(PMSG_RESTORE);
>   Enable_irqs:
>  		local_irq_enable();
> +		device_pm_unlock();
>  		enable_nonboot_cpus();
>   Resume_devices:
>  		device_resume(PMSG_RESTORE);
> 

Would it be possible to create common function for hibernation and
kexec? Keeping complex stuff like this in sync is ugly.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/