linux-kernel - Re: [PATCH 02/24] x86: kernel/apm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080807094754.GA32164@erda.amd.com>
Date:	Thu, 7 Aug 2008 11:47:58 +0200
From:	Robert Richter <robert.richter@....com>
To:	"Gustavo F. Padovan" <gustavo@....ic.unicamp.br>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu
Subject: Re: [PATCH 02/24] x86: kernel/apm_32.c cleanup

On 28.07.08 18:09:09, Gustavo F. Padovan wrote:
> Remove additional whitespaces and tabs.
> 
> Signed-off-by: Gustavo F. Padovan <gustavo@....ic.unicamp.br>
> ---
>  arch/x86/kernel/apm_32.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
> index 9ee24e6..b0c049c 100644
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -435,7 +435,7 @@ static const char * const apm_event_name[] = {
>  
>  typedef struct lookup_t {
>  	int	key;
> -	char 	*msg;
> +	char *msg;

Shouldn't this be a tab?

>  } lookup_t;
>  
>  /*
> @@ -1679,8 +1679,8 @@ static int apm(void *unused)
>  	unsigned short	cx;
>  	unsigned short	dx;
>  	int		error;
> -	char 		*power_stat;
> -	char 		*bat_stat;
> +	char	*power_stat;
> +	char	*bat_stat;

Why not using same indention as for error?

-Robert

>  
>  #ifdef CONFIG_SMP
>  	/* 2002/08/01 - WT
> -- 
> 1.5.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@....com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/