linux-kernel - Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080807010615.GB24761@verge.net.au>
Date:	Thu, 7 Aug 2008 11:06:16 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	Matthew Wilcox <matthew@....cx>,
	Sven Wegener <sven.wegener@...aler.net>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [patch] PCI: check the return value of
	device_create_bin_file() in pci_create_bus()

On Thu, Aug 07, 2008 at 10:30:26AM +1000, Michael Ellerman wrote:
> On Thu, 2008-08-07 at 09:30 +1000, Simon Horman wrote:
> > Check the return value of device_create_bin_file in pci_create_bus and
> > unwind if necessary. Don't propagate error to caller, as failure to create
> > these files shouldn't prevent PCI from being initialised.
> > 
> > Cc: Sven Wegener <sven.wegener@...aler.net>
> > Cc: Michael Ellerman <michael@...erman.id.au>
> > Cc: Matthew Wilcox <matthew@....cx>
> > Signed-off-by: Simon Horman <horms@...ge.net.au>
> 
> I hate to prolong the pain, but wasn't the plan to print a big fat
> warning so that it's clear the system is not 100% happy.

Sorry, I fogot about that bit.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/