linux-kernel - Re: [Bug 11267] SD cards stopped working on my machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0808071623210.559@blonde.site>
Date:	Thu, 7 Aug 2008 16:31:49 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	Romano Giannetti <romanol@...omillas.es>
cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	bugme-daemon@...zilla.kernel.org, drzeus-mmc@...eus.cx,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [Bug 11267] SD cards stopped working on my machine

On Thu, 7 Aug 2008, Romano Giannetti wrote:
> I just posted a regression bug on bugzilla:
> 
> 	http://bugzilla.kernel.org/show_bug.cgi?id=11267
> 
> the new kernel stopped to notice the fact that I introduce an SD card into the
> slot of the machine. It used to work perfectly in 2.6.26 (came back and
> tested, so it's not hardware).
> 
> In 2.6.26 I had on the dmesg:
> 
> [  131.145237] mmc0: new high speed SD card at address b368
> [  131.145295] PM: Adding info for mmc:mmc0:b368
> [  131.176370] mmcblk0: mmc0:b368 SD    2009600KiB (ro)
> [  131.176370] PM: Adding info for No Bus:mmcblk0
> [  131.176370]  mmcblk0: p1
> [  131.176434] PM: Adding info for No Bus:mmcblk0p1
> [  131.176434] PM: Adding info for No Bus:179:0
> 
> In 2.6.27-rc2 nothing happens. I have not a lot of time in my hands, so if
> it's possible at all I'd like to avoid a bisect (It's more than one hour per
> compile here...)

Please try yesterday's patch from the scsi-rc-fixes tree,
commit d211f052fa58a053639bc51501cb64421157d362
which fixed SD cards over USB storage for me:

[SCSI] sd: fix USB devices incorrectly reporting DIF support

Some USB devices set the protect bit in the INQUIRY data which
currently causes the DIF code in sd to assume (incorrectly) that they
support READ_CAPACITY(16).  Fix this (only for the time being) by
making sure we only believe the protect bit in the inquiry data if the
device claims conformance to SCSI-3 or above.

Acked-by: Martin K. Petersen <martin.petersen@...cle.com>
Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
---

diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 291d56a..80b2e93 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -6,6 +6,7 @@
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
 #include <linux/blkdev.h>
+#include <scsi/scsi.h>
 #include <asm/atomic.h>
 
 struct request_queue;
@@ -426,7 +427,7 @@ static inline int scsi_device_enclosure(struct scsi_device *sdev)
 
 static inline int scsi_device_protection(struct scsi_device *sdev)
 {
-	return sdev->inquiry[5] & (1<<0);
+	return sdev->scsi_level > SCSI_2 && sdev->inquiry[5] & (1<<0);
 }
 
 #define MODULE_ALIAS_SCSI_DEVICE(type) \
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/