linux-kernel - Re: PCI: Limit VPD length for Broadcom 5708S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808070856.34679.jbarnes@virtuousgeek.org>
Date:	Thu, 7 Aug 2008 08:56:34 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Dean Hildebrand <seattleplus@...il.com>
Cc:	linux-kernel@...r.kernel.org, dada1@...mosbay.com
Subject: Re: PCI: Limit VPD length for Broadcom 5708S

On Tuesday, August 5, 2008 11:49 am Dean Hildebrand wrote:
> > I have no idea if 5706S and 5709S also needs this truncation ofVPDlength
>
> It seems that our IBM Blade servers using 5706S also require this
> fix.  We have confirmed that the patch below works on 2.6.27-rc1.
>
>
> diff -uprN linux-2.6.27-rc1/drivers/pci/quirks.c
> linux-2.6.27-rc1-fix/drivers/pci/quirks.c
> --- linux-2.6.27-rc1/drivers/pci/quirks.c       2008-08-05
> 10:51:42.000000000 -0700
> +++ linux-2.6.27-rc1-fix/drivers/pci/quirks.c   2008-08-05
> 10:50:57.000000000 -0700
> @@ -1756,9 +1756,10 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_VI
>    */
>   static void __devinit quirk_brcm_570x_limit_vpd(struct pci_dev *dev)
>   {
> -       /*  Only disable the VPD capability for 5706, 5708, and 5709
> rev. A */
> +       /*  Only disable the VPD capability for 5706, 5706S, 5708, and
> 5709 rev. A */
>          if ((dev->device == PCI_DEVICE_ID_NX2_5706) ||
>              (dev->device == PCI_DEVICE_ID_NX2_5708) ||
> +           (dev->device == PCI_DEVICE_ID_NX2_5706S) ||
>              ((dev->device == PCI_DEVICE_ID_NX2_5709) &&
>               (dev->revision & 0xf0) == 0x0)) {
>                  if (dev->vpd)

Looks fine.  Can you respin against my for-linus branch and resubmit with a 
signed-off-by and full changelog?

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/