linux-kernel - Re: [PATCH 1/2] pci: add misrouted interrupt error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1218130607.3749.32.camel@localhost.localdomain>
Date:	Thu, 07 Aug 2008 10:36:47 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Greg KH <greg@...ah.com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/2] pci: add misrouted interrupt error handling

On Thu, 2008-08-07 at 10:20 -0700, Greg KH wrote:
> On Thu, Aug 07, 2008 at 09:03:22AM -0700, Jesse Barnes wrote:
> > On Tuesday, August 5, 2008 2:54 pm James Bottomley wrote:
> > > > or somesuch.  That seems just as simple for driver writers as your
> > > > initial patch, and the function is named in accordance with what it
> > > > actually does, rather than what it's used for...
> > >
> > > It could, but if the bridge is the culprit (as it usually is for MSI
> > > problems), this print won't help identify it.
> > >
> > > Therefore, rather than give driver writers a recipe for "print this and
> > > this and go to the bridge and print this", I'd rather have a single PCI
> > > callback that prints all the (hopefully) relevant information that will
> > > allow either fixing or blacklisting.
> > 
> > So in addition to the IRQ type check we need to dump some device topology 
> > information... yeah that makes sense.  I wonder if the driver core should 
> > provide something like this.  Greg?
> 
> What kind of topology do you need that is not already provided?

We really need to print how the device interrupt is routed.  But,
unfortunately, we need to identify the devices in the layout (bridges
and the like by say device/vendor numbers) so we know what they are ...
this is the bit that the generic device model can't do because it's
embedded in the bus specific part.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/