linux-kernel - Re: [PATCH] x86: removes extra assignment from arch/x86/kernel/ldt.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <489B4DD0.8080607@goop.org>
Date:	Thu, 07 Aug 2008 12:32:32 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Rakib Mullick <rakib.mullick@...il.com>
CC:	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: removes extra assignment from arch/x86/kernel/ldt.c

Rakib Mullick wrote:
> Hello guys, this patch removes an extra assignment from "write_ldt" function.
> Thanks.
>
> Signed-off-by : Md.Rakib H. Mullick (rakib.mullick@...il.com)
>
> --- linux-2.6.27-rc2.orig/arch/x86/kernel/ldt.c	2008-08-06
> 16:23:53.000000000 +0600
> +++ linux-2.6.27-rc2/arch/x86/kernel/ldt.c	2008-08-06 19:18:50.984268144 +0600
> @@ -191,11 +191,12 @@ static int write_ldt(void __user *ptr, u
>  	error = -EINVAL;
>  	if (bytecount != sizeof(ldt_info))
>  		goto out;
> -	error = -EFAULT;
> -	if (copy_from_user(&ldt_info, ptr, sizeof(ldt_info)))
> +
> +	if (copy_from_user(&ldt_info, ptr, sizeof(ldt_info))) {
> +		error = -EFAULT;
>  		goto out;
> +	}
>   

It would be better to move the EFAULT check up above so the EINVAL 
checks are adjacent.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/