linux-kernel - Re: 2.6.27-rc1: softcursor behaviour changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080807220755.GA11460@elf.ucw.cz>
Date:	Fri, 8 Aug 2008 00:07:55 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>, krzysztof.h1@...zta.fm,
	adaplas@....net, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org
Subject: Re: 2.6.27-rc1: softcursor behaviour changed

On Thu 2008-08-07 12:17:21, Stefano Stabellini wrote:
> Pavel Machek wrote:
> 
> > Hi!
> > 
> >> In 2.6.26, this 
> >>
> >>     echo -e "\33[10;5000]\33[11;50]\33[?18;0;136c\33[?102m"
> >>
> >> produces some variation on cursor. on 2.6.27-rc1, I have no cursor at
> >> all :-(.
> > 
> > The patch that changed it is below... and I must say I liked the old
> > behaviour better. Unlike blinking, high-brightness background is
> > actually useful. Can we get that one reverted?
> 
> 
> The problem is not a matter of taste but a matter of correctness: the
> build_attr function in drivers/char/vt.c stores the blink attribute as
> the forth bit of the background color.
> Then in fbcon we are interpreting the same forth bit of the background
> color as intensity bit.

...which works pretty well. We can't reasonably blink in fbcon, so we
highlight it with bright background, instead. Even old VGA had option
to do that.

> My patch fixes that.

AFAICS high bit is now completely ignored now. That makes it
useless...

For example I can no longer see my cursor.

So, if 2.6.26 behaviour is "incorrect", can you show example where it
matters, and how your patch "helps"?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/