linux-kernel - Re: [PATCH -next] drm: sis depends on FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.0.82.0808080008050.13875@skynet.skynet.ie>
Date:	Fri, 8 Aug 2008 00:09:42 +0100 (IST)
From:	Dave Airlie <airlied@...ux.ie>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] drm: sis depends on FB_SIS


> From: Randy Dunlap <randy.dunlap@...cle.com>
> cc: airlied@...ux.ie
> 
> drm/sis calls mm functions in fb/sis, so make the former depend
> on the latter.
> 
> This one happened with FB_SIS=m, AGP_SIS=y, DRM_SYS=y.
> 
> sis1.out:sis_mm.c:(.text+0x70014): undefined reference to `sis_free'
> sis1.out:sis_mm.c:(.text+0x7002a): undefined reference to `sis_malloc'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

NAK but I've no idea what the right answer is.

If someone asks for sisfb then sis drm uses code from it, if they don't 
ask for it it doesn't. So I want sisfb to be built in if its selected and 
sis drm is built-in.

Maybe I should just rip the dependency out completely, but this patch will 
break stuff badly, if someone was using the SIS DRM without sisfb.

Dave.

 > ---
>  drivers/gpu/drm/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20080806.orig/drivers/gpu/drm/Kconfig
> +++ linux-next-20080806/drivers/gpu/drm/Kconfig
> @@ -86,7 +86,7 @@ config DRM_MGA
>  
>  config DRM_SIS
>  	tristate "SiS video cards"
> -	depends on DRM && AGP
> +	depends on DRM && AGP && FB_SIS
>  	help
>  	  Choose this option if you have a SiS 630 or compatible video
>            chipset. If M is selected the module will be called sis. AGP
> 
> 
> ---
> ~Randy
> Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
> http://linuxplumbersconf.org/
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/