[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 8 Aug 2008 12:15:19 -0700
From: Greg KH <greg@...ah.com>
To: Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc: linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org,
Al Viro <viro@...IV.linux.org.uk>,
Stephen Smalley <sds@...ho.nsa.gov>,
James Morris <jmorris@...ei.org>,
Randy Dunlap <randy.dunlap@...cle.com>, safford@...son.ibm.com,
serue@...ux.vnet.ibm.com, sailer@...son.ibm.com, zohar@...ibm.com
Subject: Re: [PATCH 2/4] integrity: special fs magic
On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote:
> On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote:
> > - Move special fs magic number definitions to magic.h
> > - Add magic.h include
> >
> > Signed-off-by: Mimi Zohar <zohar@...ibm.com>
>
> Why? What is this patch for? Are you going to do something with these
> magic values later?
Ok, I now see the follow-up patch that does something with them.
You should say so in this patch.
And is it really ok to be doing things from userspace based on a
filesystem "magic" key? Those are numbers we have never exported to
userspace before, what happens if they are changed?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists