linux-kernel - Re: [2.6 patch] fix watchdog/wdt285.c compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 9 Aug 2008 11:05:27 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Alan Cox <alan@...hat.com>, Wim Van Sebroeck <wim@...ana.be>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [2.6 patch] fix watchdog/wdt285.c compilation

On Fri, Aug 08, 2008 at 07:03:46PM +0300, Adrian Bunk wrote:
> wdt285.c:211: error: 'KERN_WARN' undeclared (first use in this function)

It might be worth having the kernel provide an alias for KERN_WARN
to avoid these kinds of errors in the future.  Many people have
said that they make this mistake as well, I certainly have many a
time.

The problem is that we have things like KERN_ERR, KERN_CRIT rather
than KERN_ERROR and KERN_CRITICAL, but so we think "oh, we're using
shortened versions" but then you come to KERN_WARNING rather than
KERN_WARN.

However, since xxx_WARNING is a recognised name for the severity
level (see syslog(3)) we shouldn't get rid of that.

Needless to say, this fix for wdt285 still needs to get to Linus ASAP.

Acked-by: Russell King <rmk+kernel@....linux.org.uk>

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/