linux-kernel - Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080809124739.GA16308@infradead.org>
Date:	Sat, 9 Aug 2008 08:47:39 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Ian Kent <raven@...maw.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	autofs mailing list <autofs@...ux.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage

On Thu, Aug 07, 2008 at 07:40:06PM +0800, Ian Kent wrote:
> Usage of the AUTOFS_TYPE_* defines is a little confusing and
> appears inconsistent.

Not enough of an explanation for this patch.

It does:

 - move AUTOFS_TYPE_INDIRECT/AUTOFS_TYPE_DIRECT/AUTOFS_TYPE_OFFSET
   to include/linux/auto_fs4.h.  Obviously okay but should mentioned
   in the changelog.
 - add a new, unused AUTOFS_TYPE_ANY constant. Why?
 - add a new AUTOFS_TYPE_TRIGGER and use it instead of
   AUTOFS_TYPE_DIRECT or in one single case
   (AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET).  Definitively needs a good
   explanation.
 - replaces one use of sbi->type = 0 with AUTOFS_TYPE_INDIRECT (0x0001).
   Why?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/