linux-kernel - Re: [01/03] USB: add CONFIG_USB_DEBUG_MESSAGES and usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080809150439.GA5408@joi>
Date:	Sat, 9 Aug 2008 17:04:43 +0200
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [01/03] USB: add CONFIG_USB_DEBUG_MESSAGES and usb_dbg()

On Fri, Aug 08, 2008 at 06:39:17PM -0700, Greg KH wrote:
> --- a/drivers/usb/core/usb.h
> +++ b/drivers/usb/core/usb.h
> @@ -132,6 +132,28 @@ static inline int is_active(const struct
>  /* for labeling diagnostics */
>  extern const char *usbcore_name;
>  
> +/* USB debugging */
> +/* if debug is on or not for the USB core */
> +extern int usb_debug;
> +
> +#if defined(CONFIG_USB_DEBUG_MESSAGES)
> +/* macro for debugging */
> +#define usb_dbg(dev, format, arg...)					\
> +	({								\
> +		if (usb_debug)						\

maybe unlikely here?

> +			dev_printk(KERN_DEBUG , dev , format , ## arg); \
> +		0;							\
> +	})
> +#else
> +#define usb_dbg(dev, format, arg...)					\
> +	({								\
> +		if (0)							\
> +			dev_printk(KERN_DEBUG , dev , format , ## arg);	\
> +		0;							\
> +	})
> +#endif
> +
> +
>  /* sysfs stuff */
>  extern struct attribute_group *usb_device_groups[];
>  extern struct attribute_group *usb_interface_groups[];
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/