linux-kernel - Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <489DC15D.9070308@zytor.com>
Date:	Sat, 09 Aug 2008 09:10:05 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Wolfgang Walter <wolfgang.walter@...m.de>
CC:	Herbert Xu <herbert@...dor.apana.org.au>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	"viro@...IV.linux.org.uk" <viro@...iv.linux.org.uk>,
	"vegard.nossum@...il.com" <vegard.nossum@...il.com>
Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem
 with fpu state changes

Wolfgang Walter wrote:
> How could any kernel code use MMX/SSE/FPU when the interrupt case isn't 
> handled?

I don't think we have ever allowed MMX/SSE/FPU code in interrupt 
handlers.  kernel_fpu_begin()..end() lock out preemption, and so could 
only be interrupted, not preempted.

> Or is your argument that its lazy allocation itself is the problem: this 
> nesting could always happen and was a bug but only with lazy allocation it is 
> dangerous (as it may cause a spurious math fault in the race window).
> 
> If this were right than any kernel code executing SSE may trigger now a oops 
> in __switch_to() under some special circumstances.

If lazy allocation can cause the RAID code, for example (which executes 
SSE instructions in the kernel, but not at interrupt time) to start 
randomly oopsing, then lazy allocations have to be pulled.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/