linux-kernel - [PATCH] cred: add static, remove extern on function definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1218322619.24441.6.camel@brick>
Date:	Sat, 09 Aug 2008 15:56:59 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] cred: add static, remove extern on function definitions

kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition
kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
---
Introduced between next-20080729 and next-20080808

 kernel/cred.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index f89c5e5..d91cb06 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -69,7 +69,7 @@ static void put_tgcred_rcu(struct rcu_head *rcu)
 /*
  * Release a set of thread group credentials.
  */
-void put_tgcred(struct thread_group_cred *tgcred)
+static void put_tgcred(struct thread_group_cred *tgcred)
 {
 	if (atomic_dec_and_test(&tgcred->usage))
 		call_rcu(&tgcred->rcu, put_tgcred_rcu);
@@ -457,7 +457,7 @@ EXPORT_SYMBOL(override_creds);
  * Revert a temporary set of override subjective credentials to an old set,
  * discarding the override set.
  */
-extern void revert_creds(const struct cred *old)
+void revert_creds(const struct cred *old)
 {
 	const struct cred *override = current->cred;
 
-- 
1.6.0.rc1.278.g9c632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/