linux-kernel - Re: [PATCH] x86: work around gcc 3.4.x bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080809062937.GA5424@verge.net.au>
Date:	Sat, 9 Aug 2008 16:29:38 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Adrian Bunk <bunk@...nel.org>, Mark McLoughlin <markmc@...hat.com>,
	xen-devel@...ts.xensource.com,
	Eduardo Habkost <ehabkost@...hat.com>,
	Stephen Tweedie <sct@...hat.com>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
Subject: Re: [PATCH] x86: work around gcc 3.4.x bug

On Fri, Aug 08, 2008 at 01:46:07PM -0700, Jeremy Fitzhardinge wrote:
> gcc-3.4.x crashes when compiling pgd_prepopulate_pmd() when
> PREALLOCATED_PMDS == 0 and CONFIG_DEBUG_INFO is enabled.  This seems
> to avoid the problem.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> Cc: Adrian Bunk <bunk@...nel.org>
> Cc: Simon Horman <horms@...ge.net.au>
> Cc: Dhaval Giani <dhaval@...ux.vnet.ibm.com>

Hi Jeremy,

This does solve the problem I was seeing on on 3.4.5.

Acked-by: Simon Horman <horms@...ge.net.au>

> ---
> arch/x86/mm/pgtable.c |    3 +++
> 1 file changed, 3 insertions(+)
>
> ===================================================================
> --- a/arch/x86/mm/pgtable.c
> +++ b/arch/x86/mm/pgtable.c
> @@ -207,6 +207,9 @@
> 	unsigned long addr;
> 	int i;
>
> +	if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
> +		return;
> +
> 	pud = pud_offset(pgd, 0);
>
>  	for (addr = i = 0; i < PREALLOCATED_PMDS;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/