| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <12514.1218365916@redhat.com> Date: Sun, 10 Aug 2008 11:58:36 +0100 From: David Howells <dhowells@...hat.com> To: Harvey Harrison <harvey.harrison@...il.com> Cc: dhowells@...hat.com, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] cred: remove const qualifiers Harvey Harrison <harvey.harrison@...il.com> wrote: > get_new_cred clearly writes through the pointer, so const isn't > appropriate. Sparse warns thusly: > > include/linux/cred.h: In function ‘get_cred’: > include/linux/cred.h:181: warning: passing argument 1 of ‘get_new_cred’ discards qualifiers from pointer target type Sparse is wrong in this instance, it failed to note the cast. I know what I'm doing. > -static inline const struct cred *get_cred(const struct cred *cred) > +static inline struct cred *get_cred(struct cred *cred) That will break the compilation. Please don't do that. The point of my use of const in this instance is to stop people from trying to modify committed credentials directly, especially current->cred. But we still have to be able to take a reference to it. Unfortunately, C does not provide the necessary tools to do what I want. Eventually, we can probably ditch the const marks on the pointers but not yet. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists