linux-kernel - Re: [PATCH 2/4] integrity: special fs magic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF106327E5.3B04D6A9-ON852574A1.004B7A96-852574A1.004BE526@us.ibm.com>
Date:	Sun, 10 Aug 2008 09:48:58 -0400
From:	Mimi Zohar <zohar@...ibm.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Greg KH <greg@...ah.com>, James Morris <jmorris@...ei.org>,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>, safford@...son.ibm.com,
	sailer@...son.ibm.com, Stephen Smalley <sds@...ho.nsa.gov>,
	serue@...ux.vnet.ibm.com, Al Viro <viro@...IV.linux.org.uk>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Subject: Re: [PATCH 2/4] integrity: special fs magic

Christoph Hellwig <hch@...radead.org> wrote on 08/09/2008 02:47:59 PM:

 
> On Fri, Aug 08, 2008 at 12:15:19PM -0700, Greg KH wrote:
> > On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote:
> > > On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote:
> > > >     - Move special fs magic number definitions to magic.h
> > > >     - Add magic.h include
> > > > 
> > > >     Signed-off-by: Mimi Zohar <zohar@...ibm.com>
> > > 
> > > Why?  What is this patch for?  Are you going to do something with 
these
> > > magic values later?
> > 
> > Ok, I now see the follow-up patch that does something with them.
> > 
> > You should say so in this patch.
> > 
> > And is it really ok to be doing things from userspace based on a
> > filesystem "magic" key?  Those are numbers we have never exported to
> > userspace before, what happens if they are changed?
> 
> These constants re exported to userspace in struct statfs .type and
> better don't change.  Providing the symbolic names for them sounds
> like a good idea to me.  What userspace does with that or not is
> their business, and if it's utterly stupid it'll be their fault if
> it doesn't work as expected..

ok.

Mimi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/