linux-kernel - Re: [PATCH 1/2] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <489F179D.2010101@ru.mvista.com>
Date:	Sun, 10 Aug 2008 20:30:21 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Patrick Horn <phrh@...oo.com>,
	Russell King <rmk+lkml@....linux.org.uk>
Subject: Re: [PATCH 1/2] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n

Hello.

Bartlomiej Zolnierkiewicz wrote:

> [PATCH] ide: don't allow DMA to be enabled if CONFIG_IDEDMA_{ICS,PCI}_AUTO=n

> For CONFIG_IDEDMA_{ICS,PCI}_AUTO=n and/or "ide=nodma" option the host/device

    Not only that: it also would affect CompactFlash with no DMA support but 
with DMA autotuning enabled in IDE core...

> are not programmed for DMA and it is also explicitly disabled by ide_set_dma()
> (->ide_dma_check returns "-1").  However the code responsible for manually
> enabling DMA ("hdparm -d 1") has a bug which results in DMA being erroneously
> enabled - ide_set_dma() incorrectly passes "0" return value to set_using_dma().

    Heh, I've just run into this myself while trying to retro-fit Palmchip 
BK3710 IDE driver into 2.6.18 properly.

> This may work if BIOS/firmware configured the host/device for DMA and chipset
> allows independent configuration of DMA/PIO modes but won't work after suspend
> and is generally unsafe on many chipsets (possibly including data corruption
> if the same registers are used for DMA/PIO timings).

    Timeouts ensued in my case...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/