linux-kernel - Re: [PATCH -tip] x86: apic interrupts - move assignments to irqinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080811130647.GA23289@elte.hu>
Date:	Mon, 11 Aug 2008 15:06:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Andi Kleen <andi@...stfloor.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: apic interrupts - move assignments to
	irqinit_32.c


* Ingo Molnar <mingo@...e.hu> wrote:

> * Cyrill Gorcunov <gorcunov@...il.com> wrote:
> 
> > 64bit mode APIC interrupt handlers are set within irqinit_64.c.
> > Lets do tha same for 32bit mode which would help in furter code merging.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> > ---
> > 
> > I found it useful for APIC code merging process (in which
> > i'm now). So please review and test if possible.
> > Any comments are quite welcome!
> > 
> > Ugh... almost forget - the patch is over -tip tree
> > commit 62c67a7cc7dbd9c8d92d49cfd7d5ca1d8f354616
> 
> applied to tip/x86/core for more testing, thanks Cyrill.

doesnt build:

 arch/x86/mach-default/setup.c:44: warning: ‘irq2’ defined but not used
 arch/x86/kernel/irqinit_32.c: In function ‘native_init_IRQ’:
 arch/x86/kernel/irqinit_32.c:139: error: ‘irq2’ undeclared (first use in this function)
 arch/x86/kernel/irqinit_32.c:139: error: (Each undeclared identifier is reported only once
 arch/x86/kernel/irqinit_32.c:139: error: for each function it appears in.)

with:

 http://redhat.com/~mingo/misc/config-Mon_Aug_11_14_48_29_CEST_2008.bad

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/