| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Aug 2008 10:36:25 -0400 (EDT) From: Steven Rostedt <rostedt@...dmis.org> To: Christoph Lameter <cl@...ux-foundation.org> cc: Pekka Enberg <penberg@...helsinki.fi>, Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>, mathieu.desnoyers@...ymtl.ca, linux-mm@...ck.org, linux-kernel@...r.kernel.org, rdunlap@...otime.net, mpm@...enic.com, tglx@...utronix.de Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks. On Mon, 11 Aug 2008, Christoph Lameter wrote: > Pekka Enberg wrote: > > > The function call is supposed to go away when we convert kmemtrace to > > use Mathieu's markers but I suppose even then we have a problem with > > inlining? > > The function calls are overwritten with NOPs? Or how does that work? I believe in the latest version they are just a variable test. But when Mathieu's immediate code makes it in (which it is in linux-tip), we will be overwriting the conditionals with nops (Mathieu, correct me if I'm wrong here). But the calls themselves are done in the unlikely branch. This is important, as Mathieu stated in previous thread. The reason is that all the stack setup for the function call is also in the unlikely branch, and the normal fast path does not take a hit for the function call setup. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists