[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080811155318.GB4524@elte.hu>
Date: Mon, 11 Aug 2008 17:53:18 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Mike Travis <travis@....com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Jack Steiner <steiner@....com>, linux-kernel@...r.kernel.org,
"H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/6] x86_64 UV: Use LED to indicate CPU is active
* Mike Travis <travis@....com> wrote:
> +/*
> + * Illuminate "activity" LED when CPU is going "active",
> + * extinguish when going "idle".
> + */
> +static int uv_idle(struct notifier_block *nfb, unsigned long action, void *junk)
> +{
> + if (action == IDLE_START)
> + uv_set_led_bits(0, LED_CPU_ACTIVITY);
> +
> + else if (action == IDLE_END)
> + uv_set_led_bits(LED_CPU_ACTIVITY, LED_CPU_ACTIVITY);
> +
> + return NOTIFY_OK;
> +}
> +
> +static struct notifier_block uv_idle_notifier = {
> + .notifier_call = uv_idle,
> +};
>
> +/*
> + * Initialize idle led callback function
> + */
> +static __init void uv_init_led_idle_display(void)
> +{
> + /* initialize timer for activity monitor */
> + idle_notifier_register(&uv_idle_notifier);
> +}
hm, i think this is a bad idea. While putting it into the go-to-idle
codepath probably doesnt matter, putting anything into the idle wakeup
path increases latency of a rather critical codepath. The MMR write that
the LED driver is using will go out to the local bus, which, even if
it's POST-ed, if it's done frequently enough will be the cost of an IO
cycle.
No human needs to know the LED status at _that_ frequency anyway, so
it's quite pointless as well.
A much better (and faster) approach would be to sample the utilization
of the CPU and indicate that via the LED(s).
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists