linux-kernel - Re: [PATCH] Backlight driver for Tabletkiosk Sahara TouchIT-213 Tablet PC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080811134940.b3bcde83.akpm@linux-foundation.org>
Date:	Mon, 11 Aug 2008 13:49:40 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Claudio Nieder <private@...udio.ch>
Cc:	rpurdie@...ys.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Backlight driver for Tabletkiosk Sahara TouchIT-213
 Tablet PC

On Mon, 28 Jul 2008 22:03:00 +0200
Claudio Nieder <private@...udio.ch> wrote:

>
> ...
>
> +void kb3886_bl_set_intensity(int intensity)
> +{
> +	mutex_lock(&bl_mutex);
> +	intensity = intensity&0xff;
> +	outb(KB3886_ADC_DAC_PWM, KB3886_PARENT);
> +	mdelay(10);
> +	outb(KB3886_PWM0_WRITE, KB3886_IO);
> +	mdelay(10);
> +	outb(intensity, KB3886_IO);
> +	mutex_unlock(&bl_mutex);
> +}

I believe the mdelay()s could be converted to the preferable msleep()?

> ...
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/