linux-kernel - Re: [RFC 1/3] add support for exporting symbols from .S files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808121203.57182.rusty@rustcorp.com.au>
Date:	Tue, 12 Aug 2008 12:03:56 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	linux-arch@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	David Woodhouse <dwmw2@...radead.org>,
	Al Viro <viro@...iv.linux.org.uk>, linuxppc-dev@...abs.org
Subject: Re: [RFC 1/3] add support for exporting symbols from .S files

On Tuesday 12 August 2008 00:18:07 Arnd Bergmann wrote:
> This makes it possible to export symbols from assembly files, instead
> of having to export them through an extra ksyms.c file.
>
> I found this nicer to implement using a gas macro than a cpp macro.
...
> +	.ifeq BITS_PER_LONG-32
> +	.align 3
> +\symtab:
> +	.long \sym
> +	.long \strtab
> +	.else
> +	.align 4

Good work!   Hmm, you can .balign BITS_PER_LONG/8 outside the ifeq.  
Unfortunately .long doesn't do the Right Thing on 64 bit, so getting rid of 
the if is harder.

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/