linux-kernel - Re: [patch]fastboot: remove duplicate unpack_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Aug 2008 09:52:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [patch]fastboot: remove duplicate unpack_to_rootfs()


* Ingo Molnar <mingo@...e.hu> wrote:

> the dry_run variable is now unused in unpack_to_rootfs() and could be 
> eliminated.

also, while we are materially touching init/initramfs.c, that file has 
collected a few uglies in the past few years, checkpatch --file says:

  total: 7 errors, 7 warnings, 3 checks, 562 lines checked

it has a few other problems as well that can be seen if you look at the 
file. Unused macros:

 /* Diagnostic functions (stubbed out) */
 #define Assert(cond,msg)
 #define Trace(x)
 #define Tracev(x)
 #define Tracevv(x)
 #define Tracec(c,x)
 #define Tracecv(c,x)

 #define STATIC static
 #define INIT __init

lots of no-newline-after-variable-definitions instances:

 {
         int written;
         dry_run = check_only;

no-newline-before-return:

         kfree(header_buf);
         return message;
 }

so it would be nice to start off with a cleanup [strictly no code 
changed] patch.

then it also has an absolutely crazy turn-error-printouts-off hack:

 static __initdata char *message;
 static void __init error(char *x)
 {
         if (!message)
                 message = x;
 }

which is unobvious, 100% unused and should be removed.

those error()s should be pr_debug() perhaps. [this should be a second 
cleanup patch as it changes the code]

Hm?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/