linux-kernel - Re: [patch]fastboot: remove duplicate unpack_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Aug 2008 11:15:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Frans Meulenbroeks <fransmeulenbroeks@...il.com>
Cc:	Shaohua Li <shaohua.li@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [patch]fastboot: remove duplicate unpack_to_rootfs()


* Frans Meulenbroeks <fransmeulenbroeks@...il.com> wrote:

> 2008/8/13, Ingo Molnar <mingo@...e.hu>:
> >
> >  * Ingo Molnar <mingo@...e.hu> wrote:
> >
> >  > the dry_run variable is now unused in unpack_to_rootfs() and could be
> >  > eliminated.
> >
> >  also, while we are materially touching init/initramfs.c, that file has
> >  collected a few uglies in the past few years, checkpatch --file says:
> >
> >   total: 7 errors, 7 warnings, 3 checks, 562 lines checked
> >
> >  it has a few other problems as well that can be seen if you look at the
> >  file. Unused macros:
> >
> >   /* Diagnostic functions (stubbed out) */
> >   #define Assert(cond,msg)
> >   #define Trace(x)
> >   #define Tracev(x)
> >   #define Tracevv(x)
> >   #define Tracec(c,x)
> >   #define Tracecv(c,x)
> >
> >   #define STATIC static
> >   #define INIT __init
> >
> These are not really unused. A few lines later it reads:
> 
> #include "../src/inflate.c"
> 
> These macros are used within inflate.c

oh, i _knew_ i saw this zlib ugliness sometime in the past.

> (and perhaps the inclusion of inflate.c is not a good idea, maybe this 
> should be in lib.a note that inflate.c is also included in 
> init/do_mounts_rd.c; fortunately this is all init code (which is 
> probably why include was used in the first place))

definitely. It's a different patch though.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/