linux-kernel - Re: [PATCH] trace: Fix some mistakes in error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c62985530808140613n787572d5s3acb1a529285f8f@mail.gmail.com>
Date:	Thu, 14 Aug 2008 14:13:16 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	mingo@...e.hu, srostedt@...hat.com
Cc:	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trace: Fix some mistakes in error messages

2008/8/11 Frédéric Weisbecker <fweisbec@...il.com>
>
> This patch fixes some mistakes on the tracer in warning messages when debugfs fails to create tracing files.
> Kernel version: 2.6.27-rc1
>
> Regards.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> ---
> diff -rup a/kernel/trace/trace.c b/kernel/trace/trace.c
> --- a/kernel/trace/trace.c    2008-08-11 22:44:25.000000000 +0200
> +++ b/kernel/trace/trace.c    2008-08-11 23:10:39.000000000 +0200
> @@ -2881,12 +2881,12 @@ static __init void tracer_init_debugfs(v
>    entry = debugfs_create_file("available_tracers", 0444, d_tracer,
>                    &global_trace, &show_traces_fops);
>    if (!entry)
> -        pr_warning("Could not create debugfs 'trace' entry\n");
> +        pr_warning("Could not create debugfs 'available_tracers' entry\n");
>
>    entry = debugfs_create_file("current_tracer", 0444, d_tracer,
>                    &global_trace, &set_tracer_fops);
>    if (!entry)
> -        pr_warning("Could not create debugfs 'trace' entry\n");
> +        pr_warning("Could not create debugfs 'current_tracer' entry\n");
>
>    entry = debugfs_create_file("tracing_max_latency", 0644, d_tracer,
>                    &tracing_max_latency,
> @@ -2899,7 +2899,7 @@ static __init void tracer_init_debugfs(v
>                    &tracing_thresh, &tracing_max_lat_fops);
>    if (!entry)
>        pr_warning("Could not create debugfs "
> -               "'tracing_threash' entry\n");
> +               "'tracing_thresh' entry\n");
>    entry = debugfs_create_file("README", 0644, d_tracer,
>                    NULL, &tracing_readme_fops);
>    if (!entry)
> @@ -2909,13 +2909,13 @@ static __init void tracer_init_debugfs(v
>                    NULL, &tracing_pipe_fops);
>    if (!entry)
>        pr_warning("Could not create debugfs "
> -               "'tracing_threash' entry\n");
> +               "'trace_pipe' entry\n");
>
>    entry = debugfs_create_file("trace_entries", 0644, d_tracer,
>                    &global_trace, &tracing_entries_fops);
>    if (!entry)
>        pr_warning("Could not create debugfs "
> -               "'tracing_threash' entry\n");
> +               "'trace_entries' entry\n");
>
> #ifdef CONFIG_DYNAMIC_FTRACE
>    entry = debugfs_create_file("dyn_ftrace_total_info", 0444, d_tracer,


I said my kernel version was 2.6.27-rc1 but in fact it still applies
on last git tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/