| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080814070055.0a47393d@infradead.org> Date: Thu, 14 Aug 2008 07:00:55 -0700 From: Arjan van de Ven <arjan@...radead.org> To: Mark Langsdorf <mark.langsdorf@....com> Cc: "Ingo Molnar" <mingo@...e.hu>, "Linus Torvalds" <torvalds@...ux-foundation.org>, linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>, "Thomas Gleixner" <tglx@...utronix.de> Subject: Re: [PATCH](retry 3) invalidate caches before going into suspend On Thu, 14 Aug 2008 08:45:04 -0500 Mark Langsdorf <mark.langsdorf@....com> wrote: > When a CPU core is shut down, all of its caches need to be flushed > to prevent stale data from causing errors if the core is resumed. > Current Linux suspend code performs an assignment after the flush, > which can add dirty data back to the cache. On some AMD platforms, > additional speculative reads have caused crashes on resume because > of this dirty data. > > Relocate the cache flush to be the very last thing done before > halting. Tie into an assembly line so the compile will not > reorder it. Add some documentation explaining what is going > on and why we're doing this. looks good to me Acked-by: Arjan van de Ven <arjan@...ux.intel.com> -- If you want to reach me at my work email, use arjan@...ux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists