linux-kernel - Re: [PATCH 2.6.27-rc3 26/29] mdb: export task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38061.166.70.238.45.1218725372.squirrel@webmail.wolfmountaingroup.com>
Date:	Thu, 14 Aug 2008 08:49:32 -0600 (MDT)
From:	jmerkey@...fmountaingroup.com
To:	"Johannes Weiner" <hannes@...urebad.de>
Cc:	jmerkey@...fmountaingroup.com,
	"Pekka Enberg" <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, "Ingo Molnar" <mingo@...e.hu>
Subject: Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr

> jmerkey@...fmountaingroup.com writes:
>
>>> On Thu, Aug 14, 2008 at 9:14 AM,  <jmerkey@...fmountaingroup.com>
>>> wrote:
>>>> export the task_curr function to the module based kernel debugger to
>>>> enable
>>>> process back tracing and state display.
>>>>
>>>> Signed-off-by: Jeffrey Vernon Merkey (jmerkey@...fmountaingroup.com)
>>>>
>>>> --- a/kernel/sched.c    2008-08-13 14:22:32.000000000 -0600
>>>> +++ b/kernel/sched.c    2008-08-13 11:56:03.000000000 -0600
>>>> @@ -1736,6 +1736,9 @@
>>>>  {
>>>>        return cpu_curr(task_cpu(p)) == p;
>>>>  }
>>>> +#if defined(CONFIG_MDB_MODULE)
>>>> +EXPORT_SYMBOL_GPL(task_curr);
>>>> +#endif
>>>
>>> We usually don't export symbols conditionally, especially in core
>>> kernel
>>> code.
>>>
>>
>> Well,then please suggest how a kernel debugger can be module based and
>> still
>> be able to get this information some other way that's generic and
>> minimal
>> impact.
>
> EXPORT_SYMBOL_GPL(task_curr);
>
> Without the #if's.  Just export it.
>
> 	Hannes
>

OK.  That's simple and minimal.

Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/