linux-kernel - Re: [patch 1/3] kmsg: Kernel message catalog macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3ece790808140840t214ccbq6db63c33b4ebe963@mail.gmail.com>
Date:	Thu, 14 Aug 2008 08:40:06 -0700
From:	"Tim Hockin" <thockin@...kin.org>
To:	"Rusty Russell" <rusty@...tcorp.com.au>
Cc:	"Jan Kara" <jack@...e.cz>, "Pavel Machek" <pavel@....cz>,
	lf_kernel_messages@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, "Joe Perches" <joe@...ches.com>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Jochen Voß" <jochen.voss@...glemail.com>,
	"Sam Ravnborg" <sam@...nborg.org>,
	"Kunai Takashi" <kunai@...ux-foundation.jp>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Martin Schwidefsky" <schwidefsky@...ibm.com>,
	linux-s390@...r.kernel.org, "Gerrit Huizenga" <gh@...ibm.com>,
	"Michael Holzheu" <holzheu@...ibm.com>,
	"Randy Dunlap" <randy.dunlap@...cle.com>,
	"Tim Bird" <tim.bird@...sony.com>,
	"Tim Hockin" <thockin@...kin.org>
Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros.

On Aug 13, 2008 9:15 PM, "Rusty Russell" <rusty@...tcorp.com.au> wrote:

> On Wednesday 13 August 2008 17:04:11 Tim Hockin wrote:
>> But there are a number of places that have ...Well, if they're to be the
>> same messages under the manual-numbering scheme,
>
> someone has to verify that they are really the same anyway.  Not much more
> work to simply fix them in that case, is it?
>
> If it improves normal kernel messages, then everyone wins.

Oh, I agree with that.  I personally don't care much for the msg ID part of
this patch (I mean I don't care either way).  It might be nice to have man
pages, but I just see it becoming out of sync, duplicate numbers, etc.

What I want to see is the elevation of these call-sites from "it's just a
printk()" to "it's a report-worthy event and part of our user<->kernel API".  I
want people to add them when it's appropriate and then not change the strings
later.  I don't care if, in the end, they are structured strings.  I do care if
I have to run dozens of regexes against thousands of log-lines on thousands of
systems.

:)

Tim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/