[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6453C3CB8E2B3646B0D020C112613273C5AC70@sausexmb4.amd.com>
Date: Thu, 14 Aug 2008 11:41:34 -0500
From: "Langsdorf, Mark" <mark.langsdorf@....com>
To: "Pavel Machek" <pavel@...e.cz>
CC: "Greg KH" <greg@...ah.com>,
"Deguara, Joachim" <joachim.deguara@....com>, <gregkh@....cz>,
<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 01/01][retry 3] x86: L3 cache index disable for 2.6.26
> > > > + val |= 0xc0000000;
> > > > + pci_write_config_dword(dev, 0x1BC + index * 4, val
> > > & ~0x40000000);
> > > > + wbinvd();
> > > > + pci_write_config_dword(dev, 0x1BC + index * 4, val);
> > >
> > > Should it do if capable() test before doing such stuff?
> >
> > I don't think so. If it got this far, it is an AMD processor
> > from family 0x10 or later, so it has wbinvd().
>
> No, I meant we should check for permissions. Filesystem permissions
> are traditionaly not enough for stuff like this. if
> (capable(CAP_ADMIN)) or something?
I see what you mean. I'll add a check again capable(CAP_SYS_ADMIN).
-Mark Langsdorf
Operating System Research Center
AMD
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists