linux-kernel - Re: [PATCH 3/3] Adapt the e100 driver to the reworked PCI PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390808141656g1896657fm6802c520b036cacc@mail.gmail.com>
Date:	Thu, 14 Aug 2008 16:56:54 -0700
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	netdev@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Jeff Garzik" <jeff@...zik.org>,
	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"pm list" <linux-pm@...ts.linux-foundation.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Stephen Hemminger" <stephen.hemminger@...tta.com>
Subject: Re: [PATCH 3/3] Adapt the e100 driver to the reworked PCI PM

On Thu, Aug 14, 2008 at 2:40 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> [Note: I have no hardware to test this patch, but it seems pretty
> straightforward.]
>
> Adapt the e100 driver to the reworked PCI PM
>
> * Use device_set_wakeup_enable() and friends as needed
> * Use pci_pme_active() to clear PME_Status and disable PME#
> * Use the observation that it is sufficient to call pci_enable_wake()
>  once, unless it fails
>
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  drivers/net/e100.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
>

We have tested the patch in our labs and systems wake from S5 just fine.

Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/