[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080815120434.GA17751@elte.hu>
Date: Fri, 15 Aug 2008 14:04:35 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Mark Langsdorf <mark.langsdorf@....com>
Cc: Arjan van de Ven <arjan@...radead.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH](retry 4) invalidate caches before going into suspend
* Mark Langsdorf <mark.langsdorf@....com> wrote:
> When a CPU core is shut down, all of its caches need to be flushed to
> prevent stale data from causing errors if the core is resumed. Current
> Linux suspend code performs an assignment after the flush, which can
> add dirty data back to the cache. On some AMD platforms, additional
> speculative reads have caused crashes on resume because of this dirty
> data.
>
> Relocate the cache flush to be the very last thing done before
> halting. Tie into an assembly line so the compile will not reorder
> it. Add some documentation explaining what is going on and why we're
> doing this.
>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@....com>
> Acked-by: Mark Borden <mark.borden@....com>
> Acked-by: Michael Hohmuth <michael.hohmuth@....com>
applied to tip/x86/urgent - thanks Mark.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists