linux-kernel - Re: [PATCH] msr: Fix NULL pointer deref due to msr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080815085714.18eb1c8e@bike.lwn.net>
Date:	Fri, 15 Aug 2008 08:57:14 -0600
From:	Jonathan Corbet <corbet@....net>
To:	djwong@...ibm.com
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] msr: Fix NULL pointer deref due to msr_open on
 nonexistent CPUs

On Thu, 14 Aug 2008 15:43:33 -0700
"Darrick J. Wong" <djwong@...ibm.com> wrote:

> msr_open tests for someone trying to open a device for a nonexistent
> CPU. However, the function always returns 0, not ret like it should,
> hence userspace can BUG the kernel trivially.  This bug was
> introduced by the cdev lock_kernel pushdown patch last May.

> -	return 0;
> +	return ret;

Oops, that was pretty silly.  Apologies for the screwup.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/