[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080815152555.GJ10029@elte.hu>
Date: Fri, 15 Aug 2008 17:25:55 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: akpm@...l.org, mingo@...hat.com, linux-kernel@...r.kernel.org,
ak@...e.de, Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>,
Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] x86_64: remove empty lines from stack traces/oopses
* Alexey Dobriyan <adobriyan@...il.com> wrote:
> On Mon, Aug 11, 2008 at 07:02:19PM +0200, Ingo Molnar wrote:
> > * Alexey Dobriyan <adobriyan@...il.com> wrote:
> >
> > > show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
> > > unsigned long *stack, unsigned long bp, char *log_lvl)
> > > {
> > > - printk("\nCall Trace:\n");
> > > + printk("Call Trace:\n");
> > > dump_trace(task, regs, stack, bp, &print_trace_ops, log_lvl);
> > > - printk("\n");
> > > }
> >
> > hm, it's nice to have stack traces stand out a bit, and to not get the
> > 'Call Trace' embedded in the middle of a printk (which happens to crash
> > or produce a stack dump).
>
> Sometimes all you have is 80x25 or just screenshot from some stupid windows
> monitoring program.
> > just to make sure i get the gist of your change, do you have a
> > 'before' and 'after' sample oops, so that we can see the difference?
>
> Any recent oops with and without empty lines after Call trace: and
> after calltrace.
ok - i've queued up your fix in tip/x86/debug.
Arjan, can the removal of empty newlines break the kerneloops.org
parser?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists