[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <b040c32a0808150924h2b93529aj803e0b923e1f96f3@mail.gmail.com>
Date: Fri, 15 Aug 2008 09:24:15 -0700
From: "Ken Chen" <kenchen@...gle.com>
To: "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
"Andrew G. Morgan" <morgan@...nel.org>
Subject: [patch] fix NPTL thread iterator construct in cap_set_pg()
The usage of while_each_pid_task() construct in cap_set_pg() looks incorrect.
The macro is meant to form 'do ... while' loop instead of a simple while loop.
I think currently it will skip thread leader of a NPTL process.
Fix by convert to 'do ... while' style.
Signed-off-by: Ken Chen <kenchen@...gle.com>
diff --git a/kernel/capability.c b/kernel/capability.c
index 0101e84..26d8eda 100644
--- a/kernel/capability.c
+++ b/kernel/capability.c
@@ -167,7 +167,7 @@ static inline int cap_set_pg
pgrp = find_vpid(pgrp_nr);
do_each_pid_task(pgrp, PIDTYPE_PGID, g) {
target = g;
- while_each_thread(g, target) {
+ do {
if (!security_capset_check(target, effective,
inheritable, permitted)) {
security_capset_set(target, effective,
@@ -175,7 +175,7 @@ static inline int cap_set_pg
ret = 0;
}
found = 1;
- }
+ } while_each_thread(g, target);
} while_each_pid_task(pgrp, PIDTYPE_PGID, g);
read_unlock(&tasklist_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists