linux-kernel - Re: [PATCH 2/2] Add Dell laptop driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080816232336.GA6992@srcf.ucam.org>
Date:	Sun, 17 Aug 2008 00:23:36 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Parag Warudkar <parag.warudkar@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Add Dell laptop driver

On Sat, Aug 16, 2008 at 07:17:05PM -0400, Parag Warudkar wrote:
> > +	da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> > +			     sizeof(struct calling_interface_token),
> > +			     GFP_KERNEL);
> 
> Isn't a NULL check required here?

To the extent that it would result in this failing gracefully before 
some other part of the kernel becomes hideously upset, sure. I have a 
hard time caring, but I can easily fix it if other people do :)

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/